[lilliput-jdk17u:lilliput] RFR: 8299478: [Lilliput/JDK17] Fix Windows build
Aleksey Shipilev
shade at openjdk.org
Tue Jan 3 17:20:26 UTC 2023
On Mon, 2 Jan 2023 19:21:24 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
> These changes should fix the Windows (and MacOS) build of Lilliput/JDK17. I'm going blindly, here, only guided by GHA.
>
> Ok?
>
> Thanks,
> Roman
Can you explain a bit why this should be `int`, and not `size_t`, like the rest of upstream `object_size()` methods?
src/hotspot/share/oops/objArrayOop.hpp line 80:
> 78: size_t osz = align_object_size(size_words);
> 79: assert(osz < max_jint, "no overflow");
> 80: return static_cast<int>(osz);
`checked_cast`?
-------------
PR: https://git.openjdk.org/lilliput-jdk17u/pull/1
More information about the lilliput-dev
mailing list