[lilliput-jdk17u:lilliput] RFR: 8299478: [Lilliput/JDK17] Fix Windows build [v2]
Roman Kennke
rkennke at openjdk.org
Tue Jan 3 17:53:52 UTC 2023
On Tue, 3 Jan 2023 17:17:24 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Can you explain a bit why this should be `int`, and not `size_t`, like the rest of upstream `object_size()` methods?
It should be size_t, and it is size_t in tip, but it is int in jdk17, and I did not want to go down the rabbit hole of changing this and all the dependencies, and thereby risk to introduce funny bugs. The code is made specifically to not overflow int, and it even checks that. I believe we should be good.
-------------
PR: https://git.openjdk.org/lilliput-jdk17u/pull/1
More information about the lilliput-dev
mailing list