[master] RFR: 8300888: [Lilliput] Remaining missing parts in the SA

[Aleksey Shipilev]

On Tue, 24 Jan 2023 15:13:29 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> With fast-locking, it is now possible to provide a safe implementation of load-Klass* (following the same principle as in the runtime: load mark, check for monitor, possibly load real mark from monitor, decode Klass* from mark). This change also fixes array layout calculation and un-blocks a number of SA tests that did not work before.

Minor nits.

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java line 401:

> 399:     // On 64 bit systems, the compressed Klass* is currently read from the mark
> 400:     // word. We need to load the whole mark, and shift the upper parts.
> 401:     long value = readCInteger(address, getJLongSize(), true);

`machDesc.getAddressSize()` might be a better fit here instead of `getJLongSize()`?

-------------

Marked as reviewed by shade (Committer).

PR: https://git.openjdk.org/lilliput/pull/67