[master] RFR: 8300888: [Lilliput] Remaining missing parts in the SA [v2]

[Roman Kennke]

On Tue, 24 Jan 2023 17:06:36 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use address size instead of long size to read the mark word
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java line 401:
> 
>> 399:     // On 64 bit systems, the compressed Klass* is currently read from the mark
>> 400:     // word. We need to load the whole mark, and shift the upper parts.
>> 401:     long value = readCInteger(address, getJLongSize(), true);
> 
> `machDesc.getAddressSize()` might be a better fit here instead of `getJLongSize()`?

Right. Both is not beautiful, but address size seems less ugly. At some point in the future all of this will go away, anyway.

-------------

PR: https://git.openjdk.org/lilliput/pull/67