[master] RFR: 8300888: [Lilliput] Remaining missing parts in the SA [v2]
Aleksey Shipilev
shade at openjdk.org
Tue Jan 24 18:27:11 UTC 2023
On Tue, 24 Jan 2023 18:07:02 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java line 401:
>>
>>> 399: // On 64 bit systems, the compressed Klass* is currently read from the mark
>>> 400: // word. We need to load the whole mark, and shift the upper parts.
>>> 401: long value = readCInteger(address, getJLongSize(), true);
>>
>> `machDesc.getAddressSize()` might be a better fit here instead of `getJLongSize()`?
>
> Right. Both is not beautiful, but address size seems less ugly. At some point in the future all of this will go away, anyway.
`getAddressSize` does not over-read accidentally on 32-bit :)
-------------
PR: https://git.openjdk.org/lilliput/pull/67
More information about the lilliput-dev
mailing list