[lilliput-jdk17u:lilliput] RFR: 8308647: [Lilliput/JDK17] Fix cross-builds

Aleksey Shipilev shade at openjdk.org
Tue May 23 15:27:41 UTC 2023


On Tue, 23 May 2023 11:53:27 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Some arches still require arrayOopDesc::header_size(BasicType) that we removed because it returns word-sized header-size, in favour of similar methods that return byte-sized header-size. Let's re-instate this old method to make cross-builds happy.
> 
> It also reduces the upstream diff. Let's see what the GHA of cross-builds say.
> 
> Testing:
>  - [ ] GHA
>  - [ ] build

src/hotspot/share/oops/arrayOop.hpp line 136:

> 134:   // array object type.
> 135:   static int header_size(BasicType type) {
> 136:     size_t typesize_in_bytes = header_size_in_bytes();

`assert(!UseCompactObjectHeaders)` there, maybe?

-------------

PR Review Comment: https://git.openjdk.org/lilliput-jdk17u/pull/24#discussion_r1202170005


More information about the lilliput-dev mailing list