[lilliput-jdk17u:lilliput] RFR: 8308647: [Lilliput/JDK17] Fix cross-builds [v2]

Roman Kennke rkennke at openjdk.org
Wed May 24 15:49:52 UTC 2023


> Some arches still require arrayOopDesc::header_size(BasicType) that we removed because it returns word-sized header-size, in favour of similar methods that return byte-sized header-size. Let's re-instate this old method to make cross-builds happy.
> 
> It also reduces the upstream diff. Let's see what the GHA of cross-builds say.
> Update: GHA shows that the change fixes what it is supposed to fix. There's more stuff though, but that's handled in other PRs.
> 
> Testing:
>  - [x] GHA
>  - [x] build

Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'lilliput' into JDK-8308647
 - Add assert
 - 8308647: [Lilliput/JDK17] Fix cross-builds

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk17u/pull/24/files
  - new: https://git.openjdk.org/lilliput-jdk17u/pull/24/files/a9e812d6..3d36724c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=24&range=01
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=24&range=00-01

  Stats: 125 lines in 4 files changed: 63 ins; 60 del; 2 mod
  Patch: https://git.openjdk.org/lilliput-jdk17u/pull/24.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/24/head:pull/24

PR: https://git.openjdk.org/lilliput-jdk17u/pull/24


More information about the lilliput-dev mailing list