[lilliput-jdk17u:lilliput] RFR: 8308647: [Lilliput/JDK17] Fix cross-builds [v2]

Aleksey Shipilev shade at openjdk.org
Wed May 24 15:49:52 UTC 2023


On Wed, 24 May 2023 15:44:52 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Some arches still require arrayOopDesc::header_size(BasicType) that we removed because it returns word-sized header-size, in favour of similar methods that return byte-sized header-size. Let's re-instate this old method to make cross-builds happy.
>> 
>> It also reduces the upstream diff. Let's see what the GHA of cross-builds say.
>> Update: GHA shows that the change fixes what it is supposed to fix. There's more stuff though, but that's handled in other PRs.
>> 
>> Testing:
>>  - [x] GHA
>>  - [x] build
>
> Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'lilliput' into JDK-8308647
>  - Add assert
>  - 8308647: [Lilliput/JDK17] Fix cross-builds

Looks fine, but I think we need to re-merge from master to get clean GHA.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/lilliput-jdk17u/pull/24#pullrequestreview-1442231447


More information about the lilliput-dev mailing list