[master] RFR: Lilliput om world

[Coleen Phillimore]

On Mon, 3 Jun 2024 11:45:12 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Added a diagnostic option UseObjectMonitorTable to maintain performance of LM_LIGHTWEIGHT locking which is now defaulted to on in mainline.
>> 
>> Incorporated Axel's patch to support other platforms with UseObjectMonitorTable (branch to slow path).
>> 
>> Tested tier 1-4 on x86.  Fails both versions of this test, but not locally:  runtime/cds/TestDefaultArchiveLoading.java.
>> 
>> tier1 aarch64 in progress.
>
> src/hotspot/share/runtime/synchronizer.cpp line 427:
> 
>> 425:       // Recursive lock successful.
>> 426:       current->inc_held_monitor_count();
>> 427:       return true;
> 
> This needs a CacheSetter
> 
> Suggestion:
> 
>       CacheSetter cache_setter(current, lock);
>   
>       // Recursive lock successful.
>       current->inc_held_monitor_count();
>       return true;

Ok, yes, I missed that the fast lock stack case set the monitor.  I was trying to keep the CacheSetter contained in lightweightSynchronizer.cpp.  I'll do some more refactoring.  Thanks for pointing this out.

-------------

PR Review Comment: https://git.openjdk.org/lilliput/pull/181#discussion_r1624300664