[master] RFR: Lilliput om world

[Coleen Phillimore]

On Mon, 3 Jun 2024 12:03:07 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/synchronizer.cpp line 427:
>> 
>>> 425:       // Recursive lock successful.
>>> 426:       current->inc_held_monitor_count();
>>> 427:       return true;
>> 
>> This needs a CacheSetter
>> 
>> Suggestion:
>> 
>>       CacheSetter cache_setter(current, lock);
>>   
>>       // Recursive lock successful.
>>       current->inc_held_monitor_count();
>>       return true;
>
> Ok, yes, I missed that the fast lock stack case set the monitor.  I was trying to keep the CacheSetter contained in lightweightSynchronizer.cpp.  I'll do some more refactoring.  Thanks for pointing this out.

Oh now I see.  If we do a recursive lock, we need to clear_object_monitor_cache for some reason I haven't figured out yet.

-------------

PR Review Comment: https://git.openjdk.org/lilliput/pull/181#discussion_r1624371840