[master] RFR: OMWorld: Removal of flags, general cleanups

[Coleen Phillimore]

On Thu, 20 Jun 2024 11:58:16 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

> Cleanups in preparation for opening up a PR to mainline for [JDK-8315884](https://bugs.openjdk.org/browse/JDK-8315884).
> 
> @coleenp I incorporated #182 into this.

The cleanups look really good.  Can you fix the spelling of consistency?

src/hotspot/cpu/x86/sharedRuntime_x86.cpp line 69:

> 67:       __ testptr(result, markWord::monitor_value);
> 68:       __ jcc(Assembler::notZero, slowCase);
> 69:     }

Did I miss this one?

src/hotspot/share/runtime/globals.hpp line 1980:

> 1978:           "monitors rather than the first word of the object.")             \
> 1979:                                                                             \
> 1980:   product(int, LightweightFastLockingSpins, 13, DIAGNOSTIC,                 \

Good.  I like the new name.

src/hotspot/share/runtime/objectMonitor.cpp line 299:

> 297: }
> 298: 
> 299: #define assert_mark_word_concistency()                                         \

While you're here. The spelling is consistency.

src/hotspot/share/utilities/vmError.cpp line 595:

> 593:                  LockingMode == LM_MONITOR ? ", lm_monitors" :
> 594:                  LockingMode == LM_LEGACY ? ", lm_legacy" :
> 595:                  LockingMode == LM_LIGHTWEIGHT ? ", lm_lightweight" : "",

Without this, I guess the only way to know which locking mode is on is via. the command line in the hs_err file.  It didn't really belong here, but maybe we want to find somewhere else for it.  Not with this change.  It's good to clean this up for this change.

-------------

Marked as reviewed by coleenp (Committer).

PR Review: https://git.openjdk.org/lilliput/pull/183#pullrequestreview-2130286349
PR Review Comment: https://git.openjdk.org/lilliput/pull/183#discussion_r1647498292
PR Review Comment: https://git.openjdk.org/lilliput/pull/183#discussion_r1647497161
PR Review Comment: https://git.openjdk.org/lilliput/pull/183#discussion_r1647495754
PR Review Comment: https://git.openjdk.org/lilliput/pull/183#discussion_r1647494230