[master] RFR: OMWorld: Removal of flags, general cleanups

[Axel Boldt-Christmas]

On Thu, 20 Jun 2024 12:26:56 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Cleanups in preparation for opening up a PR to mainline for [JDK-8315884](https://bugs.openjdk.org/browse/JDK-8315884).
>> 
>> @coleenp I incorporated #182 into this.
>
> src/hotspot/share/utilities/vmError.cpp line 595:
> 
>> 593:                  LockingMode == LM_MONITOR ? ", lm_monitors" :
>> 594:                  LockingMode == LM_LEGACY ? ", lm_legacy" :
>> 595:                  LockingMode == LM_LIGHTWEIGHT ? ", lm_lightweight" : "",
> 
> Without this, I guess the only way to know which locking mode is on is via. the command line in the hs_err file.  It didn't really belong here, but maybe we want to find somewhere else for it.  Not with this change.  It's good to clean this up for this change.

We print flags at the end which are non-default. But we do not know if someone changed them in a build. 
Should probably fix this somehow. 

Also printing all flag values, not just non-default ones would help.

-------------

PR Review Comment: https://git.openjdk.org/lilliput/pull/183#discussion_r1647515283