RFR: 8246039: SSLSocket HandshakeCompletedListeners are run on virtual threads [v2]

Bradford Wetmore wetmore at openjdk.java.net
Thu Sep 17 14:39:42 UTC 2020


On Wed, 16 Sep 2020 16:06:37 GMT, Carter Kozak <github.com+3854321+carterkozak at openjdk.org> wrote:

>> Previously each `SSLSocket.addHandshakeCompletedListener(HandshakeCompletedListener)`
>> resulted in a new OS thread for each handshake which causes spikes in
>> resource utilization and bottlenecks in high throughput systems.
>> 
>> Virtual threads should reduce the overhead while preserving behavior to
>> the extent possible.
>> 
>> Reported to openjdk security-dev here:
>> https://mail.openjdk.java.net/pipermail/security-dev/2020-July/022220.html
>
> Carter Kozak has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
> excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since
> the last revision:
>   8246039: SSLSocket HandshakeCompletedListeners are run on virtual threads
>   
>   Previously each `SSLSocket.addHandshakeCompletedListener(HandshakeCompletedListener)`
>   resulted in a new OS thread for each handshake which causes spikes in
>   resource utilization and bottlenecks in high throughput systems.
>   
>   Virtual threads should reduce the overhead while preserving behavior to
>   the extent possible.
>   
>   Reported to openjdk security-dev here:
>   https://mail.openjdk.java.net/pipermail/security-dev/2020-July/022220.html

Please wait for further consideration from Xuelei, but the changes seem good to me.

-------------

Marked as reviewed by wetmore (no project role).

PR: https://git.openjdk.java.net/loom/pull/16


More information about the loom-dev mailing list