RFR: 8246039: SSLSocket HandshakeCompletedListeners are run on virtual threads [v2]
Alan Bateman
alanb at openjdk.java.net
Sun Sep 20 08:08:09 UTC 2020
On Thu, 17 Sep 2020 14:37:15 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:
>> Carter Kozak has updated the pull request with a new target base due to a merge or a rebase. The pull request now
>> contains one commit:
>> 8246039: SSLSocket HandshakeCompletedListeners are run on virtual threads
>>
>> Previously each `SSLSocket.addHandshakeCompletedListener(HandshakeCompletedListener)`
>> resulted in a new OS thread for each handshake which causes spikes in
>> resource utilization and bottlenecks in high throughput systems.
>>
>> Virtual threads should reduce the overhead while preserving behavior to
>> the extent possible.
>>
>> Reported to openjdk security-dev here:
>> https://mail.openjdk.java.net/pipermail/security-dev/2020-July/022220.html
>
> Please wait for further consideration from Xuelei, but the changes seem good to me.
https://mail.openjdk.java.net/pipermail/security-dev/2020-September/022482.html
There is musing on possible alternatives to fix the issue but I think Brad and Xuelei are okay with changing it to
start a virtual thread per notification for now and see how it goes. So I'll merge this PR.
-------------
PR: https://git.openjdk.java.net/loom/pull/16
More information about the loom-dev
mailing list