RFR: Some more descriptive names, removed redundant asserts. Request for comments. [v3]

Coleen Phillimore coleenp at openjdk.java.net
Wed Apr 6 20:26:07 UTC 2022


On Wed, 6 Apr 2022 02:20:27 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Also, there's an if statement already for chunk_available which the compiler shouldn't have trouble optimizing.  Otherwise we should refactor freeze_fast.
>> Tested locally with make test TEST=jdk/jdk/internal/vm/Continuation since only names.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More questions

src/hotspot/share/runtime/continuation.cpp line 2097:

> 2095: 
> 2096:   // Comment needed: Just the size for the first chunk? Isn't there a linked list of chunks?
> 2097:   // Don't you need the sum of their sizes?

So this is only making space for the topmost chunk, not the entire stack frame that's frozen. (?)  So only needs the size of the topmost chunk.

-------------

PR: https://git.openjdk.java.net/loom/pull/139


More information about the loom-dev mailing list