RFR: Some more descriptive names, removed redundant asserts. Request for comments. [v3]

Ron Pressler rpressler at openjdk.java.net
Wed Apr 6 21:00:08 UTC 2022


On Wed, 6 Apr 2022 20:07:00 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More questions
>
> src/hotspot/share/runtime/continuation.cpp line 2097:
> 
>> 2095: 
>> 2096:   // Comment needed: Just the size for the first chunk? Isn't there a linked list of chunks?
>> 2097:   // Don't you need the sum of their sizes?
> 
> So this is only making space for the topmost chunk, not the entire stack frame that's frozen. (?)  So only needs the size of the topmost chunk.

That's correct

-------------

PR: https://git.openjdk.java.net/loom/pull/139


More information about the loom-dev mailing list