RFR: Cleanup ProcessTool.createJavaProcessBuilder() [v2]
Chris Plummer
cjplummer at openjdk.java.net
Fri Apr 15 21:00:36 UTC 2022
> Two issues (discovered by Alex):
>
> 1. A number of the "if" blocks are already covered by the `doubleWordArgs` loop.
> 2. The `doubleWordArgs` loop should exit with a `break` instead of a `continue`
Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
Break out of loop once noModule is set false
-------------
Changes:
- all: https://git.openjdk.java.net/loom/pull/152/files
- new: https://git.openjdk.java.net/loom/pull/152/files/4a5aeca6..62fe9413
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=loom&pr=152&range=01
- incr: https://webrevs.openjdk.java.net/?repo=loom&pr=152&range=00-01
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
Patch: https://git.openjdk.java.net/loom/pull/152.diff
Fetch: git fetch https://git.openjdk.java.net/loom pull/152/head:pull/152
PR: https://git.openjdk.java.net/loom/pull/152
More information about the loom-dev
mailing list