Integrated: Cleanup ProcessTool.createJavaProcessBuilder()

Chris Plummer cjplummer at openjdk.java.net
Fri Apr 15 22:35:42 UTC 2022


On Fri, 15 Apr 2022 20:38:47 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> Two issues (discovered by Alex):
> 
> 1. A number of the "if" blocks are already covered by the `doubleWordArgs` loop.
> 2. The `doubleWordArgs` loop should exit with a `break` instead of a `continue`
> 3. Break out of loop once noModule is set false

This pull request has now been integrated.

Changeset: e51430bd
Author:    Chris Plummer <cjplummer at openjdk.org>
URL:       https://git.openjdk.java.net/loom/commit/e51430bd91f68a6ae5db91dd34b4a0c817a307ea
Stats:     17 lines in 1 file changed: 1 ins; 15 del; 1 mod

Cleanup ProcessTool.createJavaProcessBuilder()

Reviewed-by: lmesnik

-------------

PR: https://git.openjdk.java.net/loom/pull/152


More information about the loom-dev mailing list