RFR: Loom: non-PCH build without C2 fails
Hao Sun
haosun at openjdk.java.net
Tue Jan 25 10:53:16 UTC 2022
Reproduce:
./configure --disable-precompiled-headers --with-debug-level=release --with-jvm-features=-compiler2
Error message:
=== Output from failing command(s) repeated here ===
* For target hotspot_variant-server_libjvm_objs_instanceStackChunkKlass.o:
In file included from ~/jdk_src/src/hotspot/share/oops/instanceStackChunkKlass.cpp:26:
~/jdk_src/src/hotspot/share/compiler/oopMap.inline.hpp: In member function 'void OopMapDo<OopFnT, DerivedOopFnT, ValueFilterT>::iterate_oops_do(const frame*, const RegisterMapT*, const ImmutableOopMap*)':
~/jdk_src/src/hotspot/share/compiler/oopMap.inline.hpp:66:11: error: 'UseJVMCICompiler' was not declared in this scope; did you mean 'UseCompiler'?
66 | if (UseJVMCICompiler) {
| ^~~~~~~~~~~~~~~~
| UseCompiler
Note that this failure should exist since commit 9e283a4 [1].
In this patch, we
1) add the missing header, i.e. "compiler/compiler_globals.hpp".
2) remove two redundant headers as they are included in
"compiler/oopMap.inline.hpp" already.
Test:
With this patch, builds under Linux/x86_64, Linux/aarch64 and
macOS/aarch64 succeed.
[1] https://github.com/openjdk/loom/commit/9e283a4
-------------
Commit messages:
- Loom: non-PCH build without C2 fails
Changes: https://git.openjdk.java.net/loom/pull/86/files
Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=86&range=00
Stats: 4 lines in 1 file changed: 1 ins; 2 del; 1 mod
Patch: https://git.openjdk.java.net/loom/pull/86.diff
Fetch: git fetch https://git.openjdk.java.net/loom pull/86/head:pull/86
PR: https://git.openjdk.java.net/loom/pull/86
More information about the loom-dev
mailing list