RFR: Loom: non-PCH build without C2 fails [v2]
Hao Sun
haosun at openjdk.java.net
Thu Jan 27 03:09:21 UTC 2022
> Reproduce:
>
>
> ./configure --disable-precompiled-headers --with-debug-level=release --with-jvm-features=-compiler2
>
>
> Error message:
>
>
> === Output from failing command(s) repeated here ===
> * For target hotspot_variant-server_libjvm_objs_instanceStackChunkKlass.o:
> In file included from ~/jdk_src/src/hotspot/share/oops/instanceStackChunkKlass.cpp:26:
> ~/jdk_src/src/hotspot/share/compiler/oopMap.inline.hpp: In member function 'void OopMapDo<OopFnT, DerivedOopFnT, ValueFilterT>::iterate_oops_do(const frame*, const RegisterMapT*, const ImmutableOopMap*)':
> ~/jdk_src/src/hotspot/share/compiler/oopMap.inline.hpp:66:11: error: 'UseJVMCICompiler' was not declared in this scope; did you mean 'UseCompiler'?
> 66 | if (UseJVMCICompiler) {
> | ^~~~~~~~~~~~~~~~
> | UseCompiler
>
>
> Note that this failure should exist since commit 9e283a4 [1].
>
> In this patch, we
> 1) add the missing header, i.e. "compiler/compiler_globals.hpp".
> 2) remove two redundant headers as they are included in
> "compiler/oopMap.inline.hpp" already.
>
> Test:
> With this patch, builds under Linux/x86_64, Linux/aarch64 and
> macOS/aarch64 succeed.
>
> [1] https://github.com/openjdk/loom/commit/9e283a4
Hao Sun has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge branch 'fibers' into build-noPCH-without-C2
- Loom: non-PCH build without C2 fails
Reproduce:
```
./configure --disable-precompiled-headers --with-debug-level=release --with-jvm-features=-compiler2
```
Error message:
```
=== Output from failing command(s) repeated here ===
* For target hotspot_variant-server_libjvm_objs_instanceStackChunkKlass.o:
In file included from ~/jdk_src/src/hotspot/share/oops/instanceStackChunkKlass.cpp:26:
~/jdk_src/src/hotspot/share/compiler/oopMap.inline.hpp: In member function 'void OopMapDo<OopFnT, DerivedOopFnT, ValueFilterT>::iterate_oops_do(const frame*, const RegisterMapT*, const ImmutableOopMap*)':
~/jdk_src/src/hotspot/share/compiler/oopMap.inline.hpp:66:11: error: 'UseJVMCICompiler' was not declared in this scope; did you mean 'UseCompiler'?
66 | if (UseJVMCICompiler) {
| ^~~~~~~~~~~~~~~~
| UseCompiler
```
Note that this failure should exist since commit 9e283a4 [1].
In this patch, we
1) add the missing header, i.e. "compiler/compiler_globals.hpp".
2) remove two redundant headers as they are included in
"compiler/oopMap.inline.hpp" already.
Test:
With this patch, builds under Linux/x86_64, Linux/aarch64 and
macOS/aarch64 succeed.
[1] https://github.com/openjdk/loom/commit/9e283a4
-------------
Changes:
- all: https://git.openjdk.java.net/loom/pull/86/files
- new: https://git.openjdk.java.net/loom/pull/86/files/817294eb..286123ad
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=loom&pr=86&range=01
- incr: https://webrevs.openjdk.java.net/?repo=loom&pr=86&range=00-01
Stats: 130 lines in 9 files changed: 69 ins; 36 del; 25 mod
Patch: https://git.openjdk.java.net/loom/pull/86.diff
Fetch: git fetch https://git.openjdk.java.net/loom pull/86/head:pull/86
PR: https://git.openjdk.java.net/loom/pull/86
More information about the loom-dev
mailing list