Need a review/commit for MACOSX_PORT-515

[Alexander Zuev]

Scott,

   as the macosx-port workspace is frozen you will have to push your 
changes into the jdku7-osx-gate workspace and the process is slightly 
different there. First - the rule for pushing into the main jdk is that 
it's either the technical merge and it should have the 'Merge' comment 
in it or you will have to put the bugster link to the comment, external 
bug tracking tools will not fit there. This issue for some reason 
haven't been moved to the bugster - have no idea why though - so you 
will have to submit this issue there yourself. If there's any trouble 
with submitting it to bugster - tell me i will give more detailed 
information on how to do so. Then you will need to get the technical 
review in the same way you had it now but for the bugster CR. After 
you've got the positive technical review you will have to ask for the 
push approval from the workspace gatekeepers by sending formal request 
to the jdk7u-dev at openjdk.java.net alias with CC to the macosx-port-dev 
alias. The subject should be like

[jdk7u-osx] Request for approval for 1234567 - Full CR synopsis of that bug.
In the message body you will have to state what change you are about to 
commit, who was the technical reviewer and give a link to the webrev, 
bugster and mail in archive where change were reviewed (see attached 
example request from Sergey for guidelines).

After you got the push approval and if by that time you will not have 
the push permission to the jdk7u-osx-gate (jdk7u-osx is read-only for 
most of the folks) i will be happy to assist pushing your change there. 
Change will not appear in jdk7u-osx immediately though and you will have 
to wait at least a day until it settles up.

Take into consideration that coding and formatting checks are in place 
in jdku7-osx-* workspaces and they are stricter than they were in 
macosx-port, so no tabs in place of spaces, no trailing spaces in line, 
push comments should be carefully forged, all that stuff. Checks are 
automatic and if your fix is not passing them then system will not allow 
you to push it.

With best regards,
Alexander Zuev

On 12/27/11 19:42, Scott Kovatch wrote:
> http://java.net/jira/browse/MACOSX_PORT-515
>
> Can someone review and check in the patch I attached to this bug?  This is keeping us from getting a clean run of the deployment test suite.
>
> Thanks,
> Scott K.
>
> ----------------------------------------
> Scott Kovatch
> scott.kovatch at oracle.com
> Santa Clara/Pleasanton, CA
>
>