Request for review: 7141739: [osx] Local attach fails if java.io.tmpdir is set

[Daniel D. Daugherty]

Forgot to say: Thumbs up!

Dan


On 2/1/12 3:59 PM, Daniel D. Daugherty wrote:
> On 2/1/12 9:05 AM, Staffan Larsen wrote:
>> Please review the following change.
>>
>> webrev: http://cr.openjdk.java.net/~sla/7141739/webrev.00/
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141739
>>
>> This is a followup of bug 7132199 which is fixed in jdk8 and jdk7u-dev.
>>
>> If the user sets -Djava.io.tmpdir to something else than /tmp, the 
>> attach framework will fail (for example jstack). The reason is that 
>> Hotspot and the jdk does not agree on which directory the well-known 
>> .java_pid and .attach_pid files should be in. On OSX Hotspot will 
>> always create these in the per-user secure temporary directory, but 
>> the jdk will look in java.io.tmpdir.
>>
>> This fix makes sure the jdk looks in the same location as Hotspot.
>>
>> Thanks,
>> /Staffan
>
> Please update copyright years to 2012.
>
> src/solaris/classes/sun/tools/attach/BsdVirtualMachine.java
>     line 73: Always creates the ".attach_pid" file in tmpdir.
>         The HSX side matches this and always looks for the
>         ".attach_pid" file in tmpdir. Perhaps we should change
>         Linux and Solaris to always create and look for the
>         ".attach_pid" file in tmpdir...
>
> src/solaris/native/sun/tools/attach/BsdVirtualMachine.c
>     No comments.