[8] Review request for 7124513: [macosx] Support NSTexturedBackgroundWindowMask/different titlebar styles to create unified toolbar

Artem Ananiev artem.ananiev at oracle.com
Mon Jul 2 11:11:27 PDT 2012


Hi, Sergey,

a few comments:

1. AquaUtils: "textured".equals() should be replaced with 
"textured".equalsIgnoreCase()

2. CPlatformWindow: "!isOpaque() && !peer.isTextured()" - should it be 
replaced with "!isOpaque() || peer.isTextured()"? Otherwise LWWindowPeer 
and CPlatformWindow will get out of sync: textured LWP will be 
"isTranslucent() == true", while textured CPW will not be filled with 
clearColor in CPW.setOpaque(false).

Thanks,

Artem

On 7/2/2012 5:46 PM, Sergey Bylokhov wrote:
> Hi Everyone,
> Please review the fix.
> 1 When the property "apple.awt.brushMetalLook" is set we draw our panels
> and toolbars with composite=SRc and alpha=0.
> 2 Changes in JViewport are needed, because copyArea does not handle
> correctly content with alpha!=1.0.
>
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124513
> Webrev can be found at: http://cr.openjdk.java.net/~serb/7124513/webrev.00/
>
> Also note that this CR depends from CR 7124244.
>
> --
> Best regards, Sergey.
>


More information about the macosx-port-dev mailing list