[8] Review request for 7124513: [macosx] Support NSTexturedBackgroundWindowMask/different titlebar styles to create unified toolbar

[Sergey Bylokhov]

Hi, Artem.
Thanks for review. See comments inline:

02.07.2012 22:11, Artem Ananiev wrote:
> Hi, Sergey,
>
> a few comments:
>
> 1. AquaUtils: "textured".equals() should be replaced with 
> "textured".equalsIgnoreCase()
Well I can change it, but the same logic was used in CPlatformWindow for 
"textured","unified","hud". I think it would be good to leave it as is 
or change them all.
>
> 2. CPlatformWindow: "!isOpaque() && !peer.isTextured()" - should it be 
> replaced with "!isOpaque() || peer.isTextured()"? Otherwise 
> LWWindowPeer and CPlatformWindow will get out of sync: textured LWP 
> will be "isTranslucent() == true", while textured CPW will not be 
> filled with clearColor in CPW.setOpaque(false).
Yes. We set background color to clearColor for the non opaque window, 
because otherwise nswindow background is visible through opengl content. 
But in case of textured window this is exactly what we expect.
>
> Thanks,
>
> Artem
>
> On 7/2/2012 5:46 PM, Sergey Bylokhov wrote:
>> Hi Everyone,
>> Please review the fix.
>> 1 When the property "apple.awt.brushMetalLook" is set we draw our panels
>> and toolbars with composite=SRc and alpha=0.
>> 2 Changes in JViewport are needed, because copyArea does not handle
>> correctly content with alpha!=1.0.
>>
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124513
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/7124513/webrev.00/
>>
>> Also note that this CR depends from CR 7124244.
>>
>> -- 
>> Best regards, Sergey.
>>


-- 
Best regards, Sergey.