review request (L): 7012648/JDK: move JSR 292 to package java.lang.invoke and adjust names
John Rose
john.r.rose at oracle.com
Wed Mar 23 22:30:21 PDT 2011
Thanks for the review, Christian. Here's a little bit more...
Here's an updated webrev:
http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.01/
http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.01.nontriv/
The "nontriv" version is everything *except* trivial package renames.
Here are the changes since the previous webrev:
http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.00-to-01.diff
There's one more code cleanup, to fix a buglet I noticed in error checking of MH.bindTo.
Most of the new changes are due to a scrub pass, changing the form of verbs from imperative to indicative. This conforms with relevant javadoc style guidelines:
http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#styleguide
-- John
On Mar 23, 2011, at 8:30 PM, John Rose wrote:
> On Mar 23, 2011, at 3:45 AM, Christian Thalinger wrote:
>
>> On Mar 23, 2011, at 10:10 AM, John Rose wrote:
>>> http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.00/
>>>
>>> Summary: JDK code for package and class renaming from java.dyn to java.lang.invoke.
>>>
>>> Includes certain other small changes:
>>> - move remaining (miscellaneous) contents of sun.dyn to sun.invoke
>>> - make minor revisions to documentation during Public Review
>>> - remove the out-of-scope term "SAM type" from documentation and code
>>> - delete unused methods and classes
>>> - make minor (API-invisible) code cleanups
More information about the mlvm-dev
mailing list