review request (L): 7012648/JDK: move JSR 292 to package java.lang.invoke and adjust names

Christian Thalinger christian.thalinger at oracle.com
Thu Mar 24 03:38:29 PDT 2011


On Mar 24, 2011, at 6:30 AM, John Rose wrote:
> Thanks for the review, Christian.  Here's a little bit more...
> 
> Here's an updated webrev:
>  http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.01/
>  http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.01.nontriv/
> 
> The "nontriv" version is everything *except* trivial package renames.
> 
> Here are the changes since the previous webrev:
>  http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.00-to-01.diff
> 
> There's one more code cleanup, to fix a buglet I noticed in error checking of MH.bindTo.
> 
> Most of the new changes are due to a scrub pass, changing the form of verbs from imperative to indicative.  This conforms with relevant javadoc style guidelines:
>  http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#styleguide

Looks good.  -- Christian


More information about the mlvm-dev mailing list