review request (XL): 6939861: JVM should handle more conversion operations

Christian Thalinger christian.thalinger at oracle.com
Thu May 12 07:58:11 PDT 2011


On May 11, 2011, at 6:08 PM, John Rose wrote:
> http://cr.openjdk.java.net/~jrose/6939861/webrev.jdk.06/

src/share/classes/java/lang/invoke/AdapterMethodHandle.java:

+        if (false && spreadArgCount > SPREAD_LIMIT)
+            return false;

+        if (false && slotCount + extractStackMove(target) > SPREAD_LIMIT)
+            return null;  // perhaps spreading a long[] array is going to push too much

Why are these turned off?

src/share/classes/java/lang/invoke/MethodHandleImpl.java:

+            assert(false);  //OBS

"OBS"?  Obsolete?

Otherwise looks good.

-- Christian


More information about the mlvm-dev mailing list