review request (L): 7030453: JSR 292 ClassValue.get method is too slow

John Rose john.r.rose at oracle.com
Tue Sep 20 10:43:50 PDT 2011


On Sep 20, 2011, at 1:02 AM, Christian Thalinger wrote:

> On Sep 19, 2011, at 11:58 PM, John Rose wrote:
> 
>> http://cr.openjdk.java.net/~jrose/7030453/webrev.00
> 
> src/share/classes/java/lang/ClassValue.java:
> 
> 233     /** Value stream for for hashCodeForCache.  See similar structure in ThreadLocal. */
> 
> Two for's.
> 
> 578      *  from the ehad of a non-null run, which would allow them
> 
> "ehad"?

"head"

> Otherwise I think this looks good.

Thanks!

-- John


More information about the mlvm-dev mailing list