review request (L): 7030453: JSR 292 ClassValue.get method is too slow
John Rose
john.r.rose at oracle.com
Tue Sep 20 16:10:14 PDT 2011
On Sep 19, 2011, at 2:58 PM, John Rose wrote:
> http://cr.openjdk.java.net/~jrose/7030453/webrev.00
After some comments from David Holmes (thanks David!) I added internal comments about race conditions.
I refreshed the webrev with the additional comments. I also changed one variable to be volatile, with a paragraph of comments explaining why.
(The change to volatile will inhibit CSE of ClassValue.get calls, but I think such CSE was unlikely anyway. There should be no other performance effects.)
-- John
More information about the mlvm-dev
mailing list