Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

[Konstantin Shefov]

These test are for core-libs feature, but we want to test that unused lambda forms are garbage collected using WhiteBox.fullGC() method. There are three tests that use one common class, only one of them uses whitebox api. So it is hard to move one of tests to hotspot repo.


- Konstantin

-------- Исходное сообщение --------
От: Alan Bateman <Alan.Bateman at oracle.com> 
Дата:06.09.2014  0:38  (GMT+04:00) 
Кому: Konstantin Shefov <konstantin.shefov at oracle.com>,"VLADIMIR.X.IVANOV" <vladimir.x.ivanov at oracle.com>,core-libs-dev at openjdk.java.net,mlvm-dev at openjdk.java.net 
Тема: Re: [9] Review request : JDK-8057707: TEST library enhancement: copy
  sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java 

On 05/09/2014 18:57, Konstantin Shefov wrote:
> Hello,
>
> Please review the change in testlibrary 
> https://bugs.openjdk.java.net/browse/JDK-8057707
> This change is needed for new tests for the feature "Lambda Form 
> Reduction and Caching" https://bugs.openjdk.java.net/browse/JDK-8046703
>
> Webrev of the testlibrary change: 
> http://cr.openjdk.java.net/~kshefov/8057707/webrev.00/
It seems a bit strange, are you sure this is right thing to do? I would 
have thought that tests using the hotspot whitebox library would be 
pushed to the hotspot/test tree.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/mlvm-dev/attachments/20140906/19070156/attachment.html>