[9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

Thu Sep 11 16:33:41 UTC 2014

Looks ok.

I don't like the idea of having 2 copies of WB API for hotspot and jdk.

But that's tolerable unless we have shared location for test libraries 
in top repository. Having reliable tests is more important IMO.

Best regards,
Vladimir Ivanov

On 9/5/14, 9:57 PM, Konstantin Shefov wrote:
> Hello,
>
> Please review the change in testlibrary
> https://bugs.openjdk.java.net/browse/JDK-8057707
> This change is needed for new tests for the feature "Lambda Form
> Reduction and Caching" https://bugs.openjdk.java.net/browse/JDK-8046703
>
> Webrev of the testlibrary change:
> http://cr.openjdk.java.net/~kshefov/8057707/webrev.00/
>
> JBS entry for new test dev is
> https://bugs.openjdk.java.net/browse/JDK-8057719
> Webrev for new tests is
> http://cr.openjdk.java.net/~kshefov/8057719/webrev.00/
>
> Thanks
>
> -Konstantin