[9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

[Vladimir Ivanov]

Alan,

I wasn't aware about such capability. Sounds interesting.

Since we are short on time integrating tests for JEP210 into 9 and 8u40, 
I'd suggest to remove dependency on WB API from the tests for now and 
file a followup bug to restore it once a suitable solution is found. As 
I understand, only WB.fullGC() is needed. It can be replaced with 
System.gc() call.

Best regards,
Vladimir Ivanov

On 9/12/14, 11:55 AM, Alan Bateman wrote:
> On 11/09/2014 17:33, Vladimir Ivanov wrote:
>> Looks ok.
>>
>> I don't like the idea of having 2 copies of WB API for hotspot and jdk.
>>
>> But that's tolerable unless we have shared location for test libraries
>> in top repository. Having reliable tests is more important IMO.
> Has there been any thought put in to use the jtreg's multi-root
> capability? For some time it has been possible to run subsets of jdk and
> hotspot tests with a single jtreg command. I don't know if it helps here
> but it would be good to avoid having to duplicate the code.
>
> -Alan