RFR: 8255240: Mobile builds need to exclude some modules [v3]

[Magnus Ihse Bursie]

On Fri, 23 Oct 2020 12:06:48 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> exclude some modules that are not relevant on Mobile.
>> Fix for JDK-8255240
>
> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix fi/endif issue

Changes requested by ihse (no project role).

make/autoconf/jdk-options.m4 line 191:

> 189:     INCLUDE_SA=false
> 190:   fi
> 191:   if test "x$OPENJDK_TARGET_CPU" = xios ; then

You mean OPENJDK_TARGET_OS, android/ios are not CPUs. :-)

make/common/Modules.gmk line 238:

> 236: 
> 237: ifeq ($(call isTargetOs, ios android), true)
> 238:   MODULES_FILTER += jdk.hotspot.agent

You don't need to do this since you turn off SA. There is already a 
`
ifeq ($(INCLUDE_SA), false)
  MODULES_FILTER += jdk.hotspot.agent
endif
`

make/common/Modules.gmk line 241:

> 239:   MODULES_FILTER += jdk.management
> 240:   MODULES_FILTER += jdk.management.agent
> 241:   MODULES_FILTER += jdk.sctp

While technically correct, I agree with Bob that there seem to be not much point in disabling these, if the reason is just "don't think we need them". Is there an issue with compiling these modules on mobile?

make/common/modules/LauncherCommon.gmk line 54:

> 52: ifeq ($(call isTargetOs, ios), true)
> 53:   LAUNCHER_CFLAGS += -I$(TOPDIR)/src/java.base/macosx/native/libjli
> 54: endif

Did the original file in mobile have a broken if statement? So this is like a separate bug fix? Otherwise I don't understand what I'm seeing here.

-------------

PR: https://git.openjdk.java.net/mobile/pull/10