RFR: 8255240: Mobile builds need to exclude some modules [v3]
Magnus Ihse Bursie
ihse at openjdk.java.net
Mon Oct 26 08:50:40 UTC 2020
On Sat, 24 Oct 2020 13:11:43 GMT, Bob Vandette <bobv at openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix fi/endif issue
>
> make/modules/java.desktop/Lib.gmk line 38:
>
>> 36:
>> 37: ifeq ($(call isTargetOs, android ios), false)
>> 38: include lib/Awt2dLibraries.gmk
>
> This change seems too extreme. You'll have access to the desktop module but any use of the java code in this module will fail since libawt will be missing. The real fix is to configure the sources and makefiles so the entire code path java.desktop -> native libraries is available but only for the headless toolkit. The libawt_lwawt should not be included. This may be difficult since the fontmanager is dependent this native code.
>
> If this is too difficult, you should just go back and not support the java.desktop module like you had in your first PR version. Although, every time you add a change like this which moves away from full JRE JCK compatibility, you make it more difficult to upstream these changes.
It would be possible to fix configure so mobile always use headless mode. From my PoV, it seems like the natural approach. Let me know if you need help with fixing that.
-------------
PR: https://git.openjdk.java.net/mobile/pull/10
More information about the mobile-dev
mailing list