RFR: 8333795: [mobile] allow building jdk native libs for ios/android [v2]
Johan Vos
jvos at openjdk.org
Fri Jun 14 20:08:31 UTC 2024
On Fri, 14 Jun 2024 16:13:57 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> BOOL is different on iOS versus macOS.
>> mac code should work with jboolean.
>> Looking at it again now, I don't see where `awtLoaded` is used at all, so that could just go away unless I'm missing something?
>
> I agree, it seems unused. I can only find a read in `JLI_NotifyAWTLoaded` but that is never called.
>
> I guess we should file a bug on mainline to remove this code. Question is if we should keep this hack in mobile for the time being. I guess we can do that, if it is needed to make it compile. A fix in mainline will likely trigger a manual merge later on.
Right, the skara bot will probably fail to auto-merge the upstream fix (once it's integrated), but it will auto-create a PR that requires a small manual commit, and then the automated process continues -- this happened in the past, and it works very nice.
-------------
PR Review Comment: https://git.openjdk.org/mobile/pull/26#discussion_r1640294194
More information about the mobile-dev
mailing list