RFR: 8333795: [mobile] allow building jdk native libs for ios/android [v2]

Johan Vos jvos at openjdk.org
Fri Jun 14 20:08:31 UTC 2024


On Fri, 14 Jun 2024 12:01:16 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo
>
> make/modules/java.desktop/Lib.gmk line 38:
> 
>> 36: # Create the AWT/2D libraries
>> 37: 
>> 38: ifeq ($(call isTargetOs, android ios), false)
> 
> This is acceptable for now, but I think we should try to find a more elegant way to resolve this.

True. It's a complex issue and discussion though, but I agree we need to find an elegant way as a follow-up.

> src/hotspot/share/utilities/elfFile.hpp line 28:
> 
>> 26: #define SHARE_UTILITIES_ELFFILE_HPP
>> 27: 
>> 28: #if !defined(_WINDOWS) && (!defined(__APPLE__) || defined(__BIOS__)) && !defined(_AIX)
> 
> Is this really correct?

No, that's a typo indeed. 
With `make static-libs`, this code is not yet included but it is needed in the next step (when we use `make static-libs-image` which will also build the VM.
I fixed this.

-------------

PR Review Comment: https://git.openjdk.org/mobile/pull/26#discussion_r1640292964
PR Review Comment: https://git.openjdk.org/mobile/pull/26#discussion_r1640292321


More information about the mobile-dev mailing list