RFR: 8333795: [mobile] allow building jdk native libs for ios/android [v2]

Fri Jun 14 21:03:22 UTC 2024

On Fri, 14 Jun 2024 20:03:11 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> src/hotspot/share/utilities/elfFile.hpp line 28:
>> 
>>> 26: #define SHARE_UTILITIES_ELFFILE_HPP
>>> 27: 
>>> 28: #if !defined(_WINDOWS) && (!defined(__APPLE__) || defined(__BIOS__)) && !defined(_AIX)
>> 
>> Is this really correct?
>
> No, that's a typo indeed. 
> With `make static-libs`, this code is not yet included but it is needed in the next step (when we use `make static-libs-image` which will also build the VM.
> I fixed this.

That explains why it was not discovered. Thanks, I was just wondering that.

-------------

PR Review Comment: https://git.openjdk.org/mobile/pull/26#discussion_r1640351907