RFR: 8255240: Mobile builds need to exclude some modules

[Magnus Ihse Bursie]

On Sat, 23 Mar 2024 16:30:46 GMT, Johan Vos <jvos at openjdk.org> wrote:

> This PR enables to build the static libs for ios/android for the native code in most of the modules. 
> It also adds GA scripts to build those libs on Android and iOS.
> Note that building hotspot is disabled by this PR.

make/modules/java.instrument/Lib.gmk line 66:

> 64: $(BUILD_LIBINSTRUMENT): $(call FindLib, java.base, java)
> 65: 
> 66: ifeq ($(call isTargetOs, android ios), false)

And here as well...

make/modules/jdk.hotspot.agent/Lib.gmk line 81:

> 79: 
> 80: ifeq ($(call isTargetOs, android ios), false)
> 81:   TARGETS += $(BUILD_LIBSA)

The same goes here. Also note that this is actually broken for non-android or ios builds, BUILD_LIBSA should be BUILD_LIBSAPROC...

make/modules/jdk.jdwp.agent/Lib.gmk line 73:

> 71: $(BUILD_LIBJDWP): $(call FindLib, java.base, java)
> 72: 
> 73: TARGETS += $(BUILD_LIBJDWP)

While this work, this is not normally how we do things in the build.

If you ever want to have this upstreamed, you need to put the entire SetupJdkLibrary inside the ifeq block.

-------------

PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1540777582
PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1540777359
PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1540773970