RFR: 8255240: Mobile builds need to exclude some modules

[Johan Vos]

On Wed, 27 Mar 2024 09:52:55 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> This PR enables to build the static libs for ios/android for the native code in most of the modules. 
>> It also adds GA scripts to build those libs on Android and iOS.
>> Note that building hotspot is disabled by this PR.
>
> make/modules/jdk.hotspot.agent/Lib.gmk line 81:
> 
>> 79: 
>> 80: ifeq ($(call isTargetOs, android ios), false)
>> 81:   TARGETS += $(BUILD_LIBSA)
> 
> The same goes here. Also note that this is actually broken for non-android or ios builds, BUILD_LIBSA should be BUILD_LIBSAPROC...

thanks for noticing, this is embarrassing!
I'll change that in the same way as I'll fix the above -- once I know if only the call to SetupJdkLibrary should be inside the test.

> make/modules/jdk.jdwp.agent/Lib.gmk line 73:
> 
>> 71: $(BUILD_LIBJDWP): $(call FindLib, java.base, java)
>> 72: 
>> 73: TARGETS += $(BUILD_LIBJDWP)
> 
> While this work, this is not normally how we do things in the build.
> 
> If you ever want to have this upstreamed, you need to put the entire SetupJdkLibrary inside the ifeq block.

Only the `$(eval $(call SetupJdkLibrary, BUILD_LIBJDWP` block or also the

$(BUILD_LIBJDWP): $(call FindLib, java.base, java)
TARGETS += $(BUILD_LIBJDWP)


?

-------------

PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1541023768
PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1541019970