RFR: 8255240: Mobile builds need to exclude some modules

[Magnus Ihse Bursie]

On Wed, 27 Mar 2024 12:35:21 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> make/modules/jdk.jdwp.agent/Lib.gmk line 73:
>> 
>>> 71: $(BUILD_LIBJDWP): $(call FindLib, java.base, java)
>>> 72: 
>>> 73: TARGETS += $(BUILD_LIBJDWP)
>> 
>> While this work, this is not normally how we do things in the build.
>> 
>> If you ever want to have this upstreamed, you need to put the entire SetupJdkLibrary inside the ifeq block.
>
> Only the `$(eval $(call SetupJdkLibrary, BUILD_LIBJDWP` block or also the
> 
> $(BUILD_LIBJDWP): $(call FindLib, java.base, java)
> TARGETS += $(BUILD_LIBJDWP)
> 
> 
> ?

Yeah, everything needed for the compilation. Have a look at how other libraries that are only built on specific platforms are defined (e.g. in CoreLibraries.gmk, if you struggle to find examples.)

-------------

PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1541072814