[modules-dev] 6593159: (S) Simple webrev please
Andreas Sterbenz
Andreas.Sterbenz at Sun.COM
Fri Aug 17 16:58:57 PDT 2007
Kumar Srinivasan wrote:
>
> 6593159: (launcher) does not recognise the current directory when used
> with -jam[rev1, rev2]
> Webrev:
> http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-9
Changes look fine.
I noticed something in the existing code, though: the ModuleLauncher does
a repository.install() (line 194). That should not be necessary because
the LocalRepository was created with the directory containing the file as
the source dir. That line and the construction of the URL u (line 179ff)
should probably be deleted / replaced with a simple existence test of the
file [new File(jamFileName).exists()].
Andreas.
More information about the modules-dev
mailing list