[modules-dev] 6593159: (S) Simple webrev please
Kumar Srinivasan
Kumar.Srinivasan at Sun.COM
Sat Aug 18 09:07:48 PDT 2007
No there was a reason, I left it the *.install there. There is a bug in
ExpandedJamRepository, I need to talk to Dave before yanking this out.
I can just wait till he gets back and fix all of this or putback what I
have. You guys let me know.
> Kumar Srinivasan wrote:
>
>> 6593159: (launcher) does not recognise the current directory when used
>> with -jam[rev1, rev2]
>> Webrev:
>> http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-9
>>
>
> Changes look fine.
>
> I noticed something in the existing code, though: the ModuleLauncher does
> a repository.install() (line 194). That should not be necessary because
> the LocalRepository was created with the directory containing the file as
> the source dir. That line and the construction of the URL u (line 179ff)
> should probably be deleted / replaced with a simple existence test of the
> file [new File(jamFileName).exists()].
>
> Andreas.
> _______________________________________________
> modules-dev mailing list
> modules-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/modules-dev
>
--
Kumar Srinivasan
Sun Microsystems, Java Software.
408-276-7586
More information about the modules-dev
mailing list