[modules-dev] Review please for launcher bugs
Andreas Sterbenz
Andreas.Sterbenz at Sun.COM
Tue Jul 24 17:47:46 PDT 2007
Kumar Srinivasan wrote:
>
> I need a review of these fixes asap.
> http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-6/
> [The webrev contains the CRs].
Looks fine. One minor comment:
. there should be a check for "definition == null" in
getModuleDefinitionFromJam() that throws an appropriate exception if we
don't find the module. It could be null if the JAM file is corrupt.
Andreas.
More information about the modules-dev
mailing list