[modules-dev] Review please for launcher bugs

[Stanley M. Ho]

Hi Dave,

Dave Bristor wrote:
> When a ModuleArchiveInfo is created, we don't have an "original 
> filename", we have a URL.  ExpandedJamRepository creates the 
> ModuleArchiveInfo from
>     new File(url.getFile()).getAbsolutePath()
> I don't recall why it particularly does that, probably should be 
> getCanonicalPath() if anything.

I think what is unclear is that Kumar's fix checks if the filename 
returned from ModuleArchiveInfo ends with JamUtils.EXPANDED_EXT, and 
this kinda implies that the repository implementation is returning an 
internal cached jam filename in this case.

> The URLRepository doesn't have an "original filename" at all; currently 
> it provides just the module name: this should be fixed to refer to the 
> downloaded  JAM but that's difficult at best: When the ModuleArchiveInfo 
> is created, the repository has not yet downloaded the JAM.

The URLRepository does know about the filename, otherwise it won't be 
able to figure out how to download the file later. However, the concern 
is valid that the file might not yet been downloaded when list() is 
called, so null should be returned in this case.

- Stanley