[modules-dev] java.module.ModuleArchiveInfo comments

[Stephen J. McConnell]

Apologies for the noise if the following has already been addressed ...

While browsing through module sources I noticed that the
ModuleArchiveInfo sources from the b22 (12-OCT) contains some
inconsistencies between the javadoc and implementation as related to
exception handling - specifically, the constructor documents that a
NullPointerException will be thrown for a select number of cases,
however, the implementation throws an IllegalArgumentException.  In
addition the constructor documentation asserts that a NPE will be thrown
if the lastModified argument is less than 0.

Seems to me that the source and javadoc should be update such that:

  1. Null values throw NPE relative to the repository, name
     and version parameter tests
  2. The inconsistent platform/architecture combinations and 
     the negative lastModified validation should be handled 
     though appropriate IllegalArgumentExceptions


Cheers, Steve.

P.S. Can anyone provide a public SVN url for the modules codebase?


-- 
Stephen J. McConnell
mailto:mcconnell at dpml.net
http://www.dpml.net