Review request for JDK- 8006220 Faster creation of properties

Marcus Lagergren marcus.lagergren at oracle.com
Tue Apr 30 03:21:34 PDT 2013


Given that you have verified that benchmark performance has no regressions, I think this is a great step in the direction we want to go. Less complexity and the possibility to type change spill properties similar to what dual fields already does.

+1 on the condition that performance hasn't regressed.

/M

On Apr 29, 2013, at 11:57 PM, Jim Laskey <jlaskey at me.com> wrote:

> Please review http://cr.openjdk.java.net/~jlaskey/8006220/webrev.00/index.html .  This is the preliminary work for lighter weight PropertyMaps.  The most significant changes here are the introduction of slot to basic properties, elimination of embedded fields and the elimination of SpillProperties (merged with AccessorProperty.)
> 
> As it stands, this seems to make octane slightly faster, likely due to more aggressive embedding of spill fields.  Results may vary.
> 
> 
> 
> 
> 
> 



More information about the nashorn-dev mailing list