Review request for JDK- 8006220 Faster creation of properties
Hannes Wallnoefer
hannes.wallnoefer at oracle.com
Tue Apr 30 03:33:04 PDT 2013
I like the direction of this patch.
One problem I see is that the modifiable flags field is used for
calculating the hash code of PropertyMap. Also "fieldMaximum" is
mistyped as "fieldMaxiumum" three times in PropertyMap and MapCreator.
Apart from these the patch looks good to me.
Hannes
Am 2013-04-29 23:57, schrieb Jim Laskey:
> Please review http://cr.openjdk.java.net/~jlaskey/8006220/webrev.00/index.html . This is the preliminary work for lighter weight PropertyMaps. The most significant changes here are the introduction of slot to basic properties, elimination of embedded fields and the elimination of SpillProperties (merged with AccessorProperty.)
>
> As it stands, this seems to make octane slightly faster, likely due to more aggressive embedding of spill fields. Results may vary.
>
>
>
>
>
>
More information about the nashorn-dev
mailing list