Review request for 8005801

A. Sundararajan sundararajan.athijegannathan at oracle.com
Tue Jan 8 04:12:33 PST 2013


My mistake. It was package-private and non-final. But changed to be 
private and final.  The first comment is valid though..

-Sundar

A. Sundararajan wrote:
>
> * The new file SetMethodCreator.java misses copyright header
> * SpillProperty "slot" field has been made package-private and 
> non-final. Is it used outside class and is it updated after construction?
>
> -Sundar
>
> Attila Szegedi wrote:
>> Please review https://jbs.oracle.com/bugs/browse/JDK-8005801 at 
>> http://cr.openjdk.java.net/~attila/8005801/webrev.01
>>
>> "ScriptObject.findSetMethod() is a huge, complex method. It needs to 
>> be refactored into an easy to understand form."
>>
>> Thanks,
>>   Attila.
>



More information about the nashorn-dev mailing list