hg: nashorn/jdk8/nashorn: 8005801: Refactor findSetMethod

[Marcus Lagergren]

+1

On Jan 8, 2013, at 2:14 PM, attila.szegedi at oracle.com wrote:

> Changeset: 4620ac94e7dc
> Author:    attila
> Date:      2013-01-08 14:14 +0100
> URL:       http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/4620ac94e7dc
> 
> 8005801: Refactor findSetMethod
> Summary: findSetMethod() was a very large single method, very unreadable and unmaintainable. It was broken into easy-to-understand pieces. The refactoring required introduction of a comand-object like entity, SetMethodCreator, to contain the nontrivial transient state of the algorithm that made the original big method so resistant to refactoring in the first place.
> Reviewed-by: lagergren, sundar
> 
> ! src/jdk/nashorn/internal/runtime/ScriptObject.java
> + src/jdk/nashorn/internal/runtime/SetMethodCreator.java
> ! src/jdk/nashorn/internal/runtime/SpillProperty.java
> - src/jdk/nashorn/internal/runtime/linker/Mangler.java
>