Review request JDK-8006181 : nashorn script engine does not run jrunscript's initialization script

[A. Sundararajan]

Good point. I'll add a FIXME comment there and commit the changes.

Thanks for the review.
-Sundar

Andreas Rieber wrote:
> looks good to me. The only problem is if someone has a file name 
> called '<system-init>'. So i would add a comment that it is still a 
> hack. Up to you.
>
> Andreas
>
> On 14.01.13 15:42, A. Sundararajan wrote:
>> Hi,
>>
>> Incorporated changes suggested. Please review: 
>> http://cr.openjdk.java.net/~sundar/8006181/webrev.01/
>>
>> Hi Andreas, will you please look at it and see if everything is fine?
>>
>> Thanks
>> -Sundar
>>
>> A. Sundararajan wrote:
>>> Hi,
>>>
>>> Please review http://cr.openjdk.java.net/~sundar/8006181/
>>>
>>> This fix is by Andreas Rieber. The fix is to make sure nashorn 
>>> script engine runs jrunscript's init script. Previously, nashorn 
>>> script engine did not run jrunscript's init.js due to  various 
>>> incompatibilities b/w Rhino and Nashorn implementations. But, with 
>>> Andreas' fix nashorn script engine runs a replacement "init.js".
>>>
>>> Please note that ideally we should fix JDK8's init.js copy. But, 
>>> nashorn has not yet hit main jdk repo. Also, there is a chance that 
>>> rhino *may* be removed for jdk8. So instead of waiting for all 
>>> those, I am adapting Andreas' change for the interim. With the 
>>> replacement init.js in nashorn.jar, nashorn will run jrunscript 
>>> initialization script and we can run existing scripts that use 
>>> jrunscript's init facilities. We can eventually modify jrunscript's 
>>> init.js in future.
>>>
>>> Please review.
>>>
>>> Thanks
>>> -Sundar
>>>
>>>
>>
>
>